Do not tint the icon of the selected item in Compact and Details View, and include the icon in the selection rectangle

Review Request #119018 - Created June 29, 2014 and submitted

Information
Frank Reininghaus
kde-baseapps
master
304643
Reviewers
dolphin
This is a modified version of Emmanuel's idea from https://git.reviewboard.kde.org/r/106827/

It removes the icon tinting for the selected item in Compact and Details View, and extends the selection rectangle such that it includes the icon area as well. The icon tinting can be disturbing, and having a selection rectangle that only includes the text can look a bit strange, especially in the Places Panel.

Ideally, we would also get rid of the tinting in Icons View, but the problem is that

1. Highlighting only the text makes it difficult to see what the selected item is. This was the Dolphin 2.0/KDE SC 4.8 approach, see https://bugs.kde.org/show_bug.cgi?id=295515

2. Drawing a selection rectangle around both text and icon in Icons View leads to inconsistencies with the clickable area, see https://bugs.kde.org/show_bug.cgi?id=309722#c7

3. Having a non-rectangular area, which includes exactly the icon and the text, as shown in http://bugsfiles.kde.org/attachment.cgi?id=83419 , might cause problems with different styles, see http://lists.kde.org/?l=kfm-devel&m=140257867317630&w=2
Screenshots show Places Panel, Compact and Details View with default settings before/after applying this patch.

Files


Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Mark Gaiser
Emmanuel Pescosta
Emmanuel Pescosta
Commit Hook
This review has been submitted with commit 1f69714a23a222b5edabfdad9896e58a4818729e by Frank Reininghaus to branch master.
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Loading...