Fix for "Bug 336414 - Playlist switching doesnt move highlight"
Review Request #118824 - Created June 19, 2014 and submitted
Information | |
---|---|
Ashish Madeti | |
plasma-mediacenter | |
master | |
336414 | |
Reviewers | |
plasma | |
shantanu, sinnykumari |
Whenever we added / removed any playlist, the highlight was stuck at one point i.e changing the playlist after that was not changing the highlight. This was happening because we were directly assigning value to "multiplePlaylistList.currentIndex" in qml code, which removed its previous binding. Instead we should emit the currentIndexChanged() signal and let the ListView do the rest.
Changed playlist after adding / removing a playlist. Now highlight is working fine
Good analysis and fix. It is still broken if you do the following- 1. Have multiple playlists 2. Remove a playlist 3. Add a playlist After this the highlight again stops to work, can you check?
Ship It!
This review has been submitted with commit 553bbf16a8c0f8c46b08657b773bcd91a495f68f by Ashish Madeti to branch master.
This review has been submitted with commit f5118554d78a471c28afc1f6624909ba65ac6b31 by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend.