Remove find_package(XCB) call as it is handled already by the top-level cmake file

Review Request #118763 - Created June 15, 2014 and submitted

Information
Bernd Steinhauser
oxygen
Reviewers
kde-workspace, plasma
hpereiradacosta
No idea if kde-workspace is still the right group, if not, please change.

find_package(XCB) is called without specifying the required components. This leads to linking to unused dependencies in case they are installed.

Since XCB is searched for in the top level cmake file in the repository, there is no need to search for it again. The component required there (only base XCB) is sufficient.
Although, this should be sufficient to fix the deps problem, it makes sense to link to XCB::XCB instead of ${XCB_LIBRARIES}, since the former is what is actually needed.

  
Martin Flöser
Bernd Steinhauser
Hugo Pereira Da Costa
Bernd Steinhauser
Review request changed

Status: Closed (submitted)

Loading...