Distinguish between empty properties and properties that are not set

Review Request #118645 - Created June 10, 2014 and submitted

Information
Marco Martin
kwin
Reviewers
kwin
This restores the behavior on KWin4: if I set an X property that doesn't have any data on a window, it's still information, so this makes the Xcb wrapper return an empty QByteArray that is not null.
EffectWindow::readProperty() now returns an empty QByteArray constructed the same way as it was in KWin4.
This fixes the bug https://bugs.kde.org/show_bug.cgi?id=335446
The blur effect is supposed to just apply to the whole window if a region is not passed in the property, and in that case the property is here but empty.

  

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Thomas Lübking
Marco Martin
Marco Martin
Martin Flöser
Marco Martin
Martin Flöser
Commit Hook
This review has been submitted with commit 490e733590512025783e5fae9f07edc5882e5691 by Marco Martin to branch master.
Marco Martin
Review request changed

Status: Closed (submitted)

Loading...