Support for forwarding messages

Review Request #118606 - Created June 7, 2014 and submitted

Information
Karan Luthra
trojita
master
321378
119615
Reviewers
trojita

Support for forwarding messages

Allow forwarding of a message as an attachment by means of menu actions. Forwarding takes care of mangling the subject line and marking the original message as $Forwarded".

Thanks to paalsteek for sharing his initial work on this feature.

github: http://github.com/karanluthra/trojita
branch: forwarding

Please help me test if the in-reply-to and references fields are doing their work. I can see that they are now being included in the forwarded message, but need to test more whether replying to a forwarded message nests the reply in the correct thread. (And also if there are other use-cases of these two fields in forwarding). Thanks!

Files


Issues

  • 5
  • 21
  • 0
  • 26
Description From Last Updated
"message has attachments" != "MIME type is multipart/mixed". Check the RFC which defines the MIME structure of message bodies. Actually, ... Jan Kundrát Jan Kundrát
Coding style Jan Kundrát Jan Kundrát
Unfortunately, commit 2aa1fa34b5d74bfbed639e6e97723867dd13fc1c is short on details, but (IIRC) there's a problem in the composer as it currently relies on ... Jan Kundrát Jan Kundrát
I would personally use a QStringList and append new lines in there (that saves a bunch of reallocs). Jan Kundrát Jan Kundrát
There should be a comment saying that we're deliberately *not* using tr() in here Jan Kundrát Jan Kundrát
Jan Kundrát
Karan Luthra
Jan Kundrát
Karan Luthra
Jan Kundrát
Karan Luthra
Jan Kundrát
Karan Luthra
Caspar Schutijser
Caspar Schutijser
Jan Kundrát
Karan Luthra
Jan Kundrát
Jan Kundrát
Karan Luthra
Review request changed

Status: Closed (submitted)

Loading...