Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #118180 -
Created June 3, 2014 and submitted
Aug. 20, 2014, 7:13 p.m.
bug patch for slideshow dir list missing
Please add Plasma developers to the group of reviewers.
Btw, you cannot give "Ship It" to yourself, others have to approve it.
that just a wrong click :)
thanks for reminding for the missing reviewers.
I guess nobody looked at it yet because in the list it appears as "already approved". I will ping plasma developers.
I am still waiting the plasma reviewer to approve :(, though I am using this path already.
what kind of issue? tab and space different ?
Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that.
OK, I have fix in the patch. I will upload later, if it could detect as a patch......
here the coding style looks wrong
modulo the indentation, it should be ok
Revision 2 (+2 -1)
seems the patch doesn't apply anymore, at least reviewboard complains about it
Reviewboard wasn't showing the patch, not sure why. We can't do much without it. Sorry.
Revision 3 (+2 -1)
I will fix it soon.
Revision 4 (+4 -3)
weird issue when using reviewboard with the chrome. that why the diff are always error.....
I have upload successfully with the newest fixed patch