[FIX] Make equality operator in GeoDataFlyTo compare m_view based on nodeType

Review Request #118040 - Created May 7, 2014 and submitted

Information
Calin Cruceru
marble
master
Reviewers
marble
The current implementation of GeoDataFlyTo::operator== compares the m_view's which are GeoDataAbstractView pointers and it was causing some tests to fail after implementing TestGeoDataWriter::saveAndCompareEquality method. It was also caused by the fact that the unit tests for this operator were pretty poorely written.

The implementation I propose checks the nodeType of each m_view (this' and other's) and casts it to GeoDataCamera or GeoDataLookAt according to the check.

  
Calin Cruceru
Dennis Nienhüser
Calin Cruceru
Review request changed

Status: Closed (submitted)

Change Summary:

http://commits.kde.org/marble/7c219af7ef835d172989f59e9ccb15bb26cf5e91
Loading...