Add an append(QByteArray) method to the ExtractionResult

Review Request #117996 - Created May 5, 2014 and submitted

Information
Vishesh Handa
kfilemetadata
Reviewers
baloo
mwolff
    Add an append(QByteArray) method to the ExtractionResult

    This way plugins can choose to return the data in utf8 or as a QString,
    and the clients can either just let the standard QString::fromUtf8
    function do its magic, or implement some special handling if they wish.

    This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec)

    Unfortunately, this meant discarding the extraction of WordCount from
    the Plain Text extractor. Though considering the speed difference, I
    think it is worth it.

  

Issues

  • 2
  • 1
  • 0
  • 3
Description From Last Updated
this is pure virtual in the header, no? Milian Wolff Milian Wolff
OK but then I don't get why you can compile this. You provide a definition of the pure-virtual declaration here, ... Milian Wolff Milian Wolff
Milian Wolff
Milian Wolff
Milian Wolff
Vishesh Handa
Milian Wolff
Commit Hook
Vishesh Handa
Review request changed

Status: Closed (submitted)

Loading...