Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.
Review Request #117631 - Created April 18, 2014 and submitted
The konsole button should be shown only if the konsole is enabled. There is no need to show a button which actually does nothing.
you don't need it (check below)
The konsoleButton doesn't change the visibility of the konsole. The onClicked signal doesn't exist.
replace konsoleVisible with desktop.konsoleVisible We already know that there is a property called "desktop" from view.cpp so we are already familiar with desktop.*. Introducing a new property makes it harder to understand the code. desktop.* -> its coming from view.cpp konsoleVisible -> desktop.konsoleVisible -> its coming from view.cpp
Review request changed
Remove the extra property from the SdkButtons.qml. Also the konsole should be toggled when we press the konsole button.
Revision 2 (+2 -1)