kdeplasma-addons/applets/pastebin: add two new options

Review Request #117041 - Created March 25, 2014 and discarded

Information
Gregor Mi
kdeplasma-addons
master
Reviewers
plasma
apol, dhaumann, sebas
Summary
-------
Add two options:
  1. Show confirmation before sending (to prevent accidental sending of maybe sensible data)
  2. Appearance: Restrict width on large host panel (to prevent huge icon on large panels)

How does this change manifest on screen?
----------------------------------------
Settings dialog:
  - before change: http://wstaw.org/m/2014/03/25/plasma-desktopXL1751.png
  - after change: http://wstaw.org/m/2014/03/25/screenshot_default.png

Behaviour:
  1. "Show confirmation before sending" turned on and after dropping an image: http://wstaw.org/m/2014/03/25/plasma-desktopGd1751.png
  2. "Appearance: Restrict width on large host panel"
     - turned off (default): http://wstaw.org/m/2014/03/25/plasma-desktopOt1751.png (pretty big compared to other icons in system tray)
     - turned on (new): http://wstaw.org/m/2014/03/25/plasma-desktopOL1751.png (the width is restricted so it does not eat up horizontal space)

Open issues
-----------
- Is there a default "review board TARGET_GROUP" for kdeplasma-addons review-request?

@apol: I saw that in the frameworks branch you replaced pastebin with quickshare. I haven't had the chance to test it out. Does it already have the same features as pastebin?
See screenshots in description. Test if settings are getting stored. Test with different form factors (horizontal, vertical).

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
If the "don't show again" checkbox is added, I'd initialize this to true. Dominik Haumann Dominik Haumann
You could use the dontAskAgainName here to add a checkbox to the dialog: KMessageBox::questionYesNo( QWidget *parent, const QString &text, const ... Dominik Haumann Dominik Haumann
Aleix Pol Gonzalez
Dominik Haumann
Gregor Mi
Gregor Mi
Gregor Mi
Gregor Mi
Review request changed

Status: Discarded

Change Summary:

Revisit after Plasma 5 is established

Loading...