Read/write gx:altitudeMode for KML LookAt tags

Review Request #116831 - Created March 16, 2014 and submitted

Information
Calin Cruceru
marble
master
332108
Reviewers
marble
The gx:altitudeMode can now be read from and written to KML files inside the LookAt tag.
- Moved the altitudeMode getter and setter from GeoDataCamera up to GeoDataAbstractView;
- Changed KmlaltitudeModeTagHandler and KmlGxAltitudeModeTagHandler to check for GeoDataAbstractView instead of GeoDataCamera;
- Now the altitude mode in KmlLookAtTagWriter is written just like in KmlCameraTagWriter;
- Added a <gx:altitudeMode>clampToSeaFloor</gx:altitudeMode> to tests/data/LookAtTest.kml.
I tested it using tests/TestGeoDataWriter and it works as expected.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Still needs to be compared for equality, and ideally our test cases would reveal this as a regression ;-) altitudeMode() ... Dennis Nienhüser Dennis Nienhüser
Calin Cruceru
Dennis Nienhüser
Commit Hook
This review has been submitted with commit 6f665f734f4bd21933398680ef2aa7dbec0bd144 by Dennis Nienhüser on behalf of Cruceru Calin-Cristian to branch master.
Calin Cruceru
Review request changed

Status: Closed (submitted)

Loading...