Fix incorrect use of KDateTime.toTime_t in kio_http

Review Request #116784 - Created March 13, 2014 and submitted

Information
Dawit Alemayehu
kdelibs
origin/KDE/4.12
Reviewers
kdelibs
ahartmetz, dfaure
The attached patch does the following:

- It corrects a mistake in assumption that KDateTime.toTime_t() will return -1 for invalidate dates. It does not. The result is an overflow which is interpreted in kio_http as a timestamp in the distant future which obviously is wrong. See https://bugs.kde.org/show_bug.cgi?id=331774 for example. This assumption also affects the timestamp variables used for cache management.

- It converts cache management timestamp variables to 64 bits so they can accomodates dates beyond Feb 7, 2106.

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Jarvie
David Jarvie
Commit Hook
This review has been submitted with commit daf5c44b166041a049d24c1bd9c20582b6a1d3f2 by Dawit Alemayehu to branch KDE/4.12.
Dawit Alemayehu
Review request changed

Status: Closed (submitted)

Loading...