add kopete protocol QQ

Review Request #116605 - Created March 5, 2014 and updated

Information
zhang jun
kopete
Reviewers
kopete
Because qq kopete previous protocol have not used, so the basis of an protocol with Lwqq: https://github.com/xiehuc/lwqq.git, now realize the basic functions, as well as some bug to be repaired.now git Address:http://git.oschina.net/zhjun5337/kopete-qq.git

  

Issues

  • 5
  • 9
  • 0
  • 14
Description From Last Updated
maybe you should remove #kopete... Pali Rohár Pali Rohár
Fix this, please no hardcoded paths. Pali Rohár Pali Rohár
I think that these emoticons should not be installed into system wide directory, but into some kopete directory... And where ... Pali Rohár Pali Rohár
why are you adding empty lines here? Pali Rohár Pali Rohár
This looks like liblwqq is external library which was included into kopete tree... So why not to use "upstream" liblwqq ... Pali Rohár Pali Rohár
Pali Rohár
zhang jun
Pali Rohár
zhang jun
Pali Rohár
zhang jun
Review request changed
Pali Rohár
I have just looked at cmake files. I'm not going to review protocol code as I do not understand it and also I'm not going to use it...

Some other questions:
1) Will all existing qq accounts (before this patch) configured in kopete works also after applying this patch?
2) In more files which you added is some older copyright. Did you reused original qq files? If yes, maybe it could be better to not rename them (qq --> webqq)
3) Can you recheck diff and files and remove all useless whitespaces changes?
4) I do not understand why you have copy of liblwqq library in kopete tree and you are using cmake for searching for liblwqq library in system...
protocols/qq/CMakeLists.txt (Diff revision 5)
 
 
maybe you should remove #kopete...
protocols/qq/emoticons/CMakeLists.txt (Diff revision 5)
 
 
Fix this, please no hardcoded paths.
protocols/qq/emoticons/CMakeLists.txt (Diff revision 5)
 
 
I think that these emoticons should not be installed into system wide directory, but into some kopete directory...

And where is some info about these gif files? Is there your work? Or did you downloaded it from somebody? At least license is missing.

Btw original skype icons were deleted from kopete tree, because of trademark/copyright problems. And I want to prevent similar situation.
protocols/qq/icons/CMakeLists.txt (Diff revision 5)
 
 
why are you adding empty lines here?
protocols/qq/liblwqq/CMakeLists.txt (Diff revision 5)
 
 
This looks like liblwqq is external library which was included into kopete tree...

So why not to use "upstream" liblwqq library instead importing it into kopete tree?
Pali Rohár
zhang jun: Can you look at my review comments?
Pali Rohár
zhang jun: Can you look at my review comments?
Loading...