Ask user for confirmation before doing POST -> POST redirection in KIO

Review Request #116570 - Created March 7, 2014 and discarded

Information
Dawit Alemayehu
kdelibs
origin/master
Reviewers
kdelibs
aiacovitti, dfaure
This patch is a companion to the recent POST->POST redirection implementation in KIO, https://git.reviewboard.kde.org/r/116017/. It prompts the user to approve the redirection as explicitly required in sections 10.3.[2|3] of RFC 2616:

   If the 301 status code is received in response to a request other
   than GET or HEAD, the user agent MUST NOT automatically redirect the
   request unless it can be confirmed by the user, since this might
   change the conditions under which the request was issued.

Please note that this patch only prompts the user for confirmation on POST->POST redirections. It can be expanded to include redirections for other requests such as PUT.

There is also an issue of whether this patch should be part of the 4.13 release? Since we are in a freeze and the patch has both message changes as well as a new API, I have simply marked it for inclusion in master branch, i.e. 4.14.
http://greenbytes.de/tech/tc/httpredirects/t307methods.html

Files


Andrea Iacovitti
Dawit Alemayehu
Review request changed

Status: Discarded

Loading...