Do not add trailing slash on http DELETE requests
Review Request #116122 - Created Feb. 27, 2014 and submitted
This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which attempted to workaround webdav servers that do not accept delete requests on directories unless there is a trailing slash. It ensures that the "fix" is only applicable to webdav and the addition of the trailing slash is communicated to the client application.
For HTTP delete: http://greenbytes.de/tech/tc/httpredirects/t301methods.html For WebDAV delete: http://boonfaya.com/sites/webdavapps.com/#targets
Review request changed
Updated patch after testing. Makes no sense to do redirection on delete.
Revision 2 (+5 -5)
Still broken for webdav protocol (tested using konq/dolphin), can't delete file. "isFile" is always false whether you try to delete a file or folder so a trailing slash is always added.
I'm a bit lost with your latest patch uploaded... Speaking about the third patch in this review (Diff r3) it seems it works as expected. That is if a server redirects a collection DELETE operation to a new Location with trailing slash added, redirection is correctly followed. From my part it is a ship for this one (Diff r3).