Make KI18N a public dependency of KIO since public installed headers of KIO requires it

Review Request #116103 - Created Feb. 26, 2014 and submitted

Information
Matthieu Gallien
kio
master
Reviewers
kdeframeworks
include/KF5/KIOCore/kio/slavebase.h is including headers from KI18N and is publically installed.

  
Albert Astals Cid
Commit Hook
Matthieu Gallien
Review request changed

Status: Closed (submitted)

Aleix Pol Gonzalez
Ok, I just realized this was being dealt with and I did a different patch: https://git.reviewboard.kde.org/r/116573/

I think that having UI strings on a header file is quite bad TBH, but since I see there's consensus I'll discard it.
  1. Somewhat confusingly, the diff in this RR was not what was committed, but instead the diff in the comments.  See http://commits.kde.org/kio/bf41a9aa94881db1d7f85c41aa35277c6e118574
  2. My fault. I suggested Matthieu to do this, but that may not have been the best idea after all.
Loading...