Fix the numbers cut off problem in digital clock applet

Review Request #115431 - Created Feb. 2, 2014 and discarded

Information
Yichao Zhou
kde-workspace
v4.11.5
228902
Reviewers
plasma
For bug, see
https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and
https://bugs.kde.org/show_bug.cgi?id=228902

The problem is that in original code, it always uses 23:59 to calculate the width of the text.  However, in some font, AM is wider than PM, and 0 is wider than 2 and 5.  That causes some fonts been cropped.

  

Issues

  • 4
  • 2
  • 2
  • 8
Description From Last Updated
Don't do that. We're trying to avoid subpixel alignment, and this is going to introduce this kind of issues. No ... Sebastian Kügler Sebastian Kügler
"overbig" is not a word, you can use "too wide" here. Sebastian Kügler Sebastian Kügler
Coding style, brackets also around single line if statements. (also on following lines) Sebastian Kügler Sebastian Kügler
Same here: no float. Sebastian Kügler Sebastian Kügler
Yichao Zhou
Yichao Zhou
Yichao Zhou
Yichao Zhou
Yichao Zhou
Sebastian Kügler
David Edmundson
Yichao Zhou
Rex Dieter
Sebastian Kügler
Sebastian Kügler
David Edmundson
Yichao Zhou
Review request changed

Status: Discarded

Loading...