fix highlighting in the completion widget

Review Request #115161 - Created Jan. 20, 2014 and updated

Information
Mathias Kraus
rekonq
master
Reviewers
rekonq
adjam
when typing in the urlbar the first item ist not highlighted after the second letter.

due to the change in commit f0b2b230e1cd4d35f2a95c3bad94e31ecdd70de1 the widgets in the completion list are not deleted immediatelly.
when trying to highlight the widget at index 0, a search for the widget with the object name "0" is done, but because the widget might not be deleted, the old widget with the object name "0" will be found.

this patch sets the object name of the widget to an empty string (""), befor calling deleteLater().
when new suggestions are added to the list, there will be only one with the name "0", even if the old ones are not yet deleted.
compiled and checked if the highlighting works again

Files


Andrea Diamantini
Mathias Kraus
Mathias Kraus
Mathias Kraus
Mathias Kraus
Review request changed

Description:

   

when typing in the urlbar the first item ist not highlighted after the second letter.

   
   

due to the change in commit f0b2b230e1cd4d35f2a95c3bad94e31ecdd70de1 the widgets in the completion list are not deleted immediatelly.

    when trying to highlight the widget at index 0, a search for the widget with the object name "0" is done, but because the widget might not be deleted, the old widget with the object name "0" will be found.

   
~  

this patch sets the object name of the widget to "old" + index in the list, befor calling deleteLater().

  ~

this patch sets the object name of the widget to an empty string (""), befor calling deleteLater().

    when new suggestions are added to the list, there will be only one with the name "0", even if the old ones are not yet deleted.

Loading...