Add translations for visible names.

Review Request #113956 - Created Nov. 19, 2013 and updated

Information
Arnold Dumas
okteta
master
Reviewers
kossebau
Add translations for visible names.

  
Friedrich W. H. Kossebau
Good idea. But it misses important steps to be working:
a) the strings to be translated must be extracted from the source code and feed into the translator base to be translated.
b) the catalogs with the translations must be loaded into the plugin on start

If I look at the other designer plugins from KDE projects I only see the english strings, no translations (kdelibs widgets, kdepimlibs widgets, Marble). Not sure if it makes sense to offer translations at all, as nice as it would be. If you still would like to add that, here is what you need to do:

For a) you need to add a Messages.sh script to the designer/ directory (look into other Messages.sh to get the idea). This is a file which will be called automatically by the translation system on the KDE git servers, it just needs to be present and fill a proper e.g. $podir/oktetadesignerplugin.pot
For b) you need to find out how to load the proper catalogs during creation of OktetaWidgetDesignerFactoryCollection. Possibly using KCatalogLoader, not exactly sure. Check the other designer plugins based on kdelibs to see how they do it (if they do).
Friedrich W. H. Kossebau

Hi Arnold. KDE4 versions of Okteta are now in maintainance mode, master branch is KF5-based.
Any plans to pick this PR up again and react on my initial comment? Or should the PR be discarded?

  1. Sorry about this review, I've totally forgot it. I'll try to work on it during the following days.

Loading...