Fix scrollbar spacing when no scrollbar is visible in dolphin.
Review Request #113902 - Created Nov. 16, 2013 and submitted
|master, KDE/4.11, KDE/4.12|
Dolphin reserve space for scrollbar spacing even when no scrollbar is visible resulting in a ugly gap in the view when: 1. the theme uses QStyle::SH_ScrollView_FrameOnlyAroundContents and 2. the theme has a positive PM_ScrollView_ScrollBarSpacing. QtCurve can have both while Oxygen have 1 but not 2. To reproduce the problem with Oxygen style. Replace the `width += ....` (which returns -2 or 0 for Oxygen) with `width += 2`. See more info here.  https://github.com/QtCurve/qtcurve-qt4/issues/9#issuecomment-28630517
Logic looks right. Compiled and it fixes the problem.
Thanks for the patch! I cannot test it at the moment, but only taking the scrollbar spacing into account if a scroll bar is shown looks very reasonable. Concerning the branches: KDE/4.11 is sufficient for bug fixes. We merge KDE/4.11 into KDE/4.12 and KDE/4.12 into master regularly. Do you have a KDE git account?