Unbreak kauth-policy-gen

Review Request #113851 - Created Nov. 14, 2013 and submitted

Information
Aurélien Gâteau
kdelibs
frameworks
Reviewers
kdeframeworks
dafre
This is a two-commit patch, it fixes a build failure in kde-workspace/kcontrol/dateandtime.


1. make policy-gen accept a second argument pointing to the output file

2. Unbreak call to kauth-policy-gen

Uses the new kauth-policy-gen syntax for extra safety (no empty output file
gets created in case of failure)

Note: I haven't tested the Mac part of the code. Would be awesome if someone could give it a try.
Still builds, kcmclock_actions.policy is correctly generated in kde-workspace/kcontrol/dateandtime
Aurélien Gâteau
Bhushan Shah
Commit Hook
This review has been submitted with commit 00e39e1d2a8372c991e24383d7c45ea393522ca8 by Aurélien Gâteau to branch frameworks.
  1. Decided to push it without a "ship it": it fixes the build of kde-workspace on build.kde.org and a few people looked at it without being horrified.
  2. Not a big deal, the patch wasn't really intrusive. OTOH, 24hrs is still a decent reaction time :)
  3. > 24hrs is still a decent reaction time :)
    
    True, sorry for that.
    
    Thanks for reviewing it.
Aurélien Gâteau
Review request changed

Status: Closed (submitted)

Dario Freddi
Ship It!
Loading...