Split Message Handling out of text-ui into a new class ready for QML drop in later

Review Request #113448 - Created Oct. 27, 2013 and discarded

Information
David Edmundson
ktp-text-ui
master
Reviewers
telepathy
commit 655de06f7d218109f365bdbeed4c567b63e45376
Author: David Edmundson <kde@davidedmundson.co.uk>
Date:   Mon Oct 14 14:14:44 2013 -0700

    Fix notifications

commit 28a6ed3b5adcd82449d4e2ee58717ce6b0a27d78
Author: David Edmundson <kde@davidedmundson.co.uk>
Date:   Mon Oct 14 18:47:29 2013 +0000

    Split message handling out of ChatWidget into MessageView
    
    This prepares it ready for moving to the QML message view

commit 77897b72c6c5ef3a9d4d0c3753b7796cdf24768f
Author: David Edmundson <kde@davidedmundson.co.uk>
Date:   Mon Oct 14 18:46:53 2013 +0000

    Rename MessageView -> LogMessageView
    
    (it conflicts with a new class I'm about to add)

  

Issues

  • 15
  • 0
  • 0
  • 15
Description From Last Updated
Why is this a TODO? What do we need this for? Are we going to bind something to m_contactName in ... Leon Handreke Leon Handreke
Do we inherit anything useful from AbstractMessageFilter here? Leon Handreke Leon Handreke
> //tell Tp we are no longer want to s/are// Martin Klapetek Martin Klapetek
Martin Klapetek Martin Klapetek
Is this comment any useful here? Looks like it will not be true anymore soon Martin Klapetek Martin Klapetek
Tp::ReceivedMessage& message --> Tp::ReceivedMessage &message Martin Klapetek Martin Klapetek
Will this break the current behavior? Martin Klapetek Martin Klapetek
Why this->? Martin Klapetek Martin Klapetek
The comment should be in the "else" part, no? Martin Klapetek Martin Klapetek
Kill this...? Martin Klapetek Martin Klapetek
Tp::ReceivedMessage& message -> Tp::ReceivedMessage &message Martin Klapetek Martin Klapetek
str.channel()aight --> str.channel() right Martin Klapetek Martin Klapetek
&s -> right Martin Klapetek Martin Klapetek
& -> right Martin Klapetek Martin Klapetek
If you're changing this line already...you know what my comment will be ;) Martin Klapetek Martin Klapetek
Leon Handreke
David Edmundson
Martin Klapetek
David Edmundson
Review request changed

Status: Discarded

Loading...