Fix compilation rules of KDE-Workspace under OSX/Macports

Review Request #112991 - Created Sept. 29, 2013 and updated

Information
Gilles Caulier
kde-workspace
master
https://trac.macports.org/ticket/33780
Reviewers
kde-workspace
This patch fix broken compilation under OSX / macports about kde-workspace.

Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available.

By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX.

See my Macports bug report for details : https://trac.macports.org/ticket/33780 

Gilles Caulier
I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5)

As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. 

Files


Issues

  • 6
  • 0
  • 0
  • 6
Description From Last Updated
we don't need to copy the same statement into endif any more. Makes it way more maintainable :-) Martin Flöser Martin Flöser
why did you move kwin around? Martin Flöser Martin Flöser
this could go into one if statement Martin Flöser Martin Flöser
why another level of indentation. just merge the not win32 and not mac Martin Flöser Martin Flöser
empty new line? Martin Flöser Martin Flöser
here I would also just merge the two into one if statement Martin Flöser Martin Flöser
Gilles Caulier
Kurt Hindenburg
Gilles Caulier
Gilles Caulier
Gilles Caulier
Review request changed

Change Summary:

New patch to fix compile rules under OSX with KDE 4.11 branch

Added Files:

Martin Flöser

   
CMakeLists.txt (Diff revision 1)
 
 
we don't need to copy the same statement into endif any more. Makes it way more maintainable :-)
CMakeLists.txt (Diff revision 1)
 
 
 
 
 
 
 
 
 
why did you move kwin around?
CMakeLists.txt (Diff revision 1)
 
 
 
 
 
 
this could go into one if statement
kcontrol/CMakeLists.txt (Diff revision 1)
 
 
 
 
 
 
 
 
 
 
 
why another level of indentation. just merge the not win32 and not mac
kcontrol/CMakeLists.txt (Diff revision 1)
 
 
empty new line?
libs/CMakeLists.txt (Diff revision 1)
 
 
 
 
 
 
here I would also just merge the two into one if statement
Just as a matter of fact: it will need someone else to give a ship-it for it. I do not feel qualified for it from cmake and multi-platform support side. I would suggest to add Aaron to the reviewers as the workspace module coordinator.
Marko Käning

Thanks, Gilles, for letting us know, that this is covered anew by https://git.reviewboard.kde.org/r/120287/ !

Please join our discussions on MacPorts-devel and KDE-MAC mailing lists.

Greets, Marko

Loading...