Fix compilation rules of KDE-Workspace under OSX/Macports
Review Request #112991 - Created Sept. 29, 2013 and updated
This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier
I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well.
|we don't need to copy the same statement into endif any more. Makes it way more maintainable :-)||Martin Flöser|
|why did you move kwin around?||Martin Flöser|
|this could go into one if statement||Martin Flöser|
|why another level of indentation. just merge the not win32 and not mac||Martin Flöser|
|empty new line?||Martin Flöser|
|here I would also just merge the two into one if statement||Martin Flöser|
Martin, KDE 4.11 or master (Qt5) _must_ compile under OSX. My current patch work fine against master and can be applied to git repository. I currently working to adjust this patch with KDE 4.11 branch. I know that most of developers work under Linux and X11 based system. But this must not be a portability limitation, especially when people provide a patch on other platform. After all, Windows is also supported by KDE-Workspace, why not OSX. My patch simply reproduce compilation rules defined by Windows to OSX. Gilles Caulier
New patch to fix compile rules under OSX with KDE 4.11 branch
we don't need to copy the same statement into endif any more. Makes it way more maintainable :-)
why did you move kwin around?
this could go into one if statement
why another level of indentation. just merge the not win32 and not mac
empty new line?
here I would also just merge the two into one if statement
Just as a matter of fact: it will need someone else to give a ship-it for it. I do not feel qualified for it from cmake and multi-platform support side. I would suggest to add Aaron to the reviewers as the workspace module coordinator.
Thanks, Gilles, for letting us know, that this is covered anew by https://git.reviewboard.kde.org/r/120287/ !
Please join our discussions on MacPorts-devel and KDE-MAC mailing lists.