Save/Restore size of Contact VIewer Dialog

Review Request #112592 - Created Sept. 8, 2013 and submitted

Information
Allen Winter
kdepimlibs
4.11, master
Reviewers
kdepim
Save/Restore the size of the Contact Viewer Dialog.

I think this can go into 4.11 as well since I'm not changing the public interface, but I'd like someone to verify that for me.

  

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
You can initialize the second argument to QSize(500, 600) so you can omit the "if" branch below since size will ... Daniel Vrátil Daniel Vrátil
sync() is called from KConfig destructor, so no need to call it explicitely Daniel Vrátil Daniel Vrátil
Daniel Vrátil
Allen Winter
Review request changed

Status: Closed (submitted)

Kevin Krammer

   
akonadi/contact/contactviewerdialog.cpp (Diff revision 1)
 
 
Since you are using QLatin1String for constructing a QString from a string literal in the line above you should probably do this here as well if just to be consistent :)
akonadi/contact/contactviewerdialog.cpp (Diff revision 1)
 
 
see above
Loading...