Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #112507 -
Created Sept. 4, 2013 and submitted
Sept. 7, 2013, 1:03 p.m.
This fixes the linked bug.
I built and tested it with three sessions, the exported HTML looked right.
Thanks it looks good. On another topic, I wonder if it should be valid HTML w/ doctype/head/body/etc.
actually looking at the code more closely, can the " = false" just be put in closeSpan()?
Valid HTML would have the advantage that one could use a set of CSS declarations and use classes instead of literal styles in the document. Pygments (syntax highlighter) does the same thing.
The `= false` should not be put into HTMLDecoder::closeSpan(). That method is called by HTMLDecoder::end(). And there, it is just used to close the final *outter* span. I could add another method, HTMLDecode::closeInnerSpan() to do this, but that might be unneeded for two calls.
This review has been submitted with commit 9f73fbb57f0f2b2ec5c7301b9fc632cde6bd187d by Kurt Hindenburg to branch master.
This review has been submitted with commit 6b4c8925e1cc7bc599deb82d7b11016c582d4761 by Kurt Hindenburg to branch KDE/4.11.
This review has been submitted with commit b94acfce5051cda379b39b5a03bec507cf8822cf by Kurt Hindenburg to branch frameworks.