Column for Object 2 is added in conjunctions tool and default width of column is set larger
Review Request #112496 - Created Sept. 3, 2013 and submitted
|asimha, hdevalence, kulaga|
In conjunctions tool default width of column in text box is set large enough to make it look better and column "object 2" is added to keep log of to which object the object 1 is mapping, when we have calculated many conjunctions from same object 1 to different object 2s.
This is definitely a nice usability improvement. I have marked a few comments in the diff. Could you please look at them? Thanks!
It would make sense to use a const reference here instead of passing those QStrings by value. Also, I would name those arguments object1 and object2, just to be consistent with the rest of the code.
A wild whitespace appeared after "object".
Again, WS issues.
Again, maybe using object1 would be more consistent.
Comments below. With this configuration of the view, it is not possible to change the width of the "Object 2" section - this should be fixed.