FindSamba add PkgConfig fallback

Review Request #112448 - Created Sept. 2, 2013 and submitted

Information
Mark Gaiser
kdelibs
frameworks
Reviewers
buildsystem
FindSamba couldn't find samba on my machine. Perhaps because it's Samba 4 and it's include folder is /usr/include/samba-4.0/. However, "pkg-config --cflags-only-I smbclient" worked just fine and returned the correct include path. This patch falls back to pkg-config if it couldn't find samba.
Works, finds samba without issues.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
I recommend using PC_SAMBA_INCLUDEDIR and PC_SAMBA_LIBDIR as hints for the find_path / find_library calls instead eg: if(NOT WIN32) find_package(PkgConfig) if(PKG_CONFIG_FOUND) ... Christophe Giboudeaux Christophe Giboudeaux
Mark Gaiser
Christophe Giboudeaux
Rex Dieter
Mark Gaiser
Commit Hook
Mark Gaiser
Review request changed

Status: Closed (submitted)

Loading...