Do not use QFileInfo to obtain the size of a symlink in kio_trash

Review Request #112173 - Created Aug. 20, 2013 and submitted

Information
Dawit Alemayehu
kde-runtime
KDE/4.11
253776
Reviewers
kde-runtime
dfaure, tokoe
The attached patch fixes a bug where deleting a symlink to a very large file causes a "trash has reached its limit error. This happens because the code that is used to determine the amount of space available in the trashcan uses QFileInfo::size to determine the size of a file. This will not work because QFileInfo::size returns the size of the actual file the symlink points to and not the size of the symlink itself. See the documentation for QFileInfo.

  

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
David Faure
Dawit Alemayehu
David Faure
Commit Hook
This review has been submitted with commit 4e04319afc77bfb66287439386b705e7c3e5ae54 by Dawit Alemayehu to branch KDE/4.11.
Dawit Alemayehu
Review request changed

Status: Closed (submitted)

Loading...