Add utility function to paint icon overlays

Review Request #112079 - Created Aug. 14, 2013 and submitted

Information
Martin Klapetek
kdelibs
Reviewers
kdeframeworks
As this was rejected from QIcon, I decided to implement it in frameworks. The idea is new private icon engine (KOverlayIconEngine), which paints the overlays itself, and then an utility function in KIconUtils:: namespace, which takes the base icon and the overlay icons as parameters and constructs new QIcon using KOverlayIconEngine. As QPixmapIconEngine (QIcon default) is private in Qt and couldn't be simply extended, the KOverlayIconEngine simply forwards the calls to QIcon, which then forwards those calls internally to QPixmapIconEngine (QIcon is really mostly just a wrapper around an engine).

There are two functions

QIcon KIconUtils::kIconAddOverlay(const QIcon &icon, const QIcon &overlay, Qt::Corner position);

and

QIcon KIconUtils::kIconAddOverlay(const QIcon &icon, QHash<Qt::Corner, QIcon> overlays);

The first one serves for single overlay icon, the second one is then for multiple overlays, requires the QHash to be built up before passing though.
I have a small testing app with 3 QLabels, testing both ::paint() and ::pixmap() methods, all works \o/ I'm thinking about bundling the app with kguiaddons and/or additionally creating a unittest for it (I have one for Qt already), but I'll do that later as I'm off to vacation and I'd like to get comments for the code.

Issues

  • 1
  • 11
  • 6
  • 18
Description From Last Updated
What about calling this one "AddOverlays", in plural? Nicolás Alvarez Nicolás Alvarez
Aurélien Gâteau
Aurélien Gâteau
Nicolás Alvarez
Kevin Ottens
Martin Klapetek
Kevin Ottens
Martin Klapetek
Kevin Ottens
Commit Hook
Martin Klapetek
Review request changed

Status: Closed (submitted)

Loading...