Fix for Konqueror crash when adding/importing bookmarks

Review Request #112042 - Created Aug. 12, 2013 and submitted

Information
Dawit Alemayehu
kde-baseapps
KDE/4.11
309370
Reviewers
kde-baseapps
dfaure
This patch prevents Konqueror from crashing when adding/importing bookmarks.

  

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
How can m_toolBar be NULL, given this line in the only constructor? It gets deleted, and there's a QPointer? But ... David Faure David Faure
Commit Hook
This review has been submitted with commit d1963e23ddfd64c4ffb18da419dc9c3f92300341 by Dawit Alemayehu to branch KDE/4.11.
Dawit Alemayehu
Review request changed

Status: Closed (submitted)

David Faure
sorry, forgot to push my pending review...
konqueror/src/konqbookmarkbar.cpp (Diff revision 1)
 
 
How can m_toolBar be NULL, given this line in the only constructor?

It gets deleted, and there's a QPointer?

But then fillBookmarkBar might as well abort at the beginning of the method, at least?
Loading...