NepomukFeeder IndexScheduler: Report accurate percentage for items being removed
Review Request #111929 - Created Aug. 7, 2013 and submitted
Item removal seems to be a lot more CPU intensive than email indexing because of all the optimizations. The user should therefore be given a % that they can keep track of. Without this patch it just shows 0% or 100%.
Shows accurate % for item removal. Not tested to see if it still shows accurate % for items being indexed. That'll take me a couple of more hours as I have some 13k emails that need to deleted.
Not commenting on the change itself, but I think it would make a lot of sense to port the agent to ObserverV3 to get batch notifications about items removal and flag changes. Especially if Nepomuk can deal with batches, the progress reporting could be completely eliminated.
If removals need to be scheduled now as well, I think it would be better to deal with them in a separate removalQueue, with the lowest priority, just as the indexing queues. It also seems a bit counter intuitive that the progress signal is first used for indexing and then for removal, while the counters are handled internally separately. IMO they should either be combined (just counting operations), or really be separated completely (if the two i.e. can run in parallel). But feel free to ship it if this solves your needs for the moment.