resolve BC issues in libnm-qt

Review Request #111814 - Created July 31, 2013 and discarded

Information
Lukáš Tinkl
networkmanager-qt
master
Reviewers
networkmanagement
grulich, lvsouza
As agreed with lamarque on IRC, we should try to resolve any pending BC issues in libnm-qt before making its first official release.

Cf https://trello.com/c/cxR7AEAX/44-fix-binary-compatibiliy-issues-in-libmm-qt-and-libnm-qt
Compiles fine, will be running it live from now on.

Issues

  • 1
  • 0
  • 1
  • 2
Description From Last Updated
Code style: macros comes first, please swap those two lines and all similar lines throughout the patch. This patch basically ... Lamarque Souza Lamarque Souza
Lukáš Tinkl
Lamarque Souza
Lukáš Tinkl
Review request changed

Status: Discarded

Change Summary:

Turns out this patch causes more problems than expected.... crashes all around :/ 
Lamarque Souza

   
settings/bondsetting.h (Diff revision 2)
 
 
Code style: macros comes first, please swap those two lines and all similar lines throughout the patch.

This patch basically fixes a memory leak in the library: the classes that inherit from Settings and ConnectionSettings overrides the d_ptr from Settings and ConnectionSettings without deallocating its memory. I think we could avoid that and the waste of memory of allocating a SettingPrivate and ConnectionSettingPrivate by passing the *Private from the derived class to super class, like NetworkManager::Device does. There is a constructor in NetworkManager::Device with a DevicePrivate parameter just for that reason.
Loading...