Do not enable the "Create New..." menu when searching

Review Request #111805 - Created July 30, 2013 and submitted

Information
Frank Reininghaus
kde-baseapps
master
321577
Reviewers
dolphin
While an URL is being loaded, DolphinView assumes that the URL is not writable -> the "Create New..." menu is disabled.

When loading is completed, the dir lister's rootItem() is examined to decide if the URL is writable (I think that the reason for this approach is that examining it before the directory is loaded might take too long).

However, if the root item is "Null" (this happens to be the case for searches), we always assume that the URL is writable. I propose to change this default to "not writable". I don't see a problem here - can anyone imagine a situation where we have a view with a null root item that is writable?

Anyway, I'd prefer to push this to master only. The bug is not really a showstopper, and it doesn't hurt if it gets some wide testing before the commit ends up in a stable release.
The "Create New..." menu is disabled when searching. I haven't found any regressions so far.
Emmanuel Pescosta
Commit Hook
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Loading...