Fix tabs sometimes not closing using the middle mouse button

Review Request #111610 - Created July 19, 2013 and discarded

Information
Diego Soenens
rekonq
Reviewers
rekonq
If the mouse moves even 1 pixel while the middle mouse button is being pressed/clicked to close a tab it causes KTabBar to not emit mouseMiddleClick() if isMovable() == true.
As a result the tab doesn't get closed and the user has to try again and this can happen a few times in a row if the mouse has a "hard" middle mouse button. Quite annoying :(.

See: http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/ktabbar_8cpp_source.html#l00209
According to the comment it's a "compatibility feature for old middle mouse tab moving" so I'm not exactly sure if this should even be fixed to begin with and whether Rekonq is the place to do it in this case.

Edit: not sure why my diff isn't working?
Been running this patch for a few hours. Everything seems to work as intended.
Diego Soenens
Diego Soenens
Andrea Diamantini
Diego Soenens
Review request changed

Status: Discarded

Change Summary:

should be probably applied to kdelibs and discussed before in k-c-d mailing list. 
Loading...