Don't update clipboard before cut/paste KIO operation succeeds

Review Request #111585 - Created July 19, 2013 and submitted

Information
Dawit Alemayehu
kdelibs
318757
Reviewers
kdelibs
dfaure
The attached patch fixes a bug where the contents of the clipboard are prematurely updated during a cut and paste operation. In the process I also discovered that undoing the operation does not update the clipboard either. Hence that too is fixed by this patch.

Please note that this patch does not address all the cases where the content of the clipboard is not updated after a KIO operation. More specifically the clipboard content will be out of sync if the user performs the following operations:

- copy/cut a file or a directory and rename it
- copy/cut a file or a directory and move it
- copy/cut a file or a directory and delete it.

In fact there is a ticket for the copy/cut and rename file/directory scenario (bug# 134960). However, addressing these issues require a careful consideration of how to do it since delete/rename/move operations can be done outside of KDE's control. Do we simply fix the KIO jobs to handle this or do we address it the KDirWatch level so we catch all the scenarios? Probably the latter. Anyhow, that can wait until for the 134960 fix.
Unit and manual tests.

Issues

  • 0
  • 9
  • 0
  • 9
Description From Last Updated
David Faure
David Faure
David Faure
David Faure
Commit Hook
This review has been submitted with commit e4b786f6df87aba226931082e5ad2791ac529978 by Dawit Alemayehu to branch KDE/4.11.
Dawit Alemayehu
Review request changed

Status: Closed (submitted)

Loading...