Fix ViewProperties crash on MacOS (caused by infinite recursion)

Review Request #111182 - Created June 22, 2013 and submitted

Information
Frank Reininghaus
kde-baseapps
KDE/4.10
316209
Reviewers
dolphin
hindenburg
When view properties are stored in each folder, but we enter a folder without .directory file, we try to read the global view properties instead. To achieve that, we enable global view properties, then create a new ViewProperties object, and disable global view properties again.

However, if changing the "global view properties" setting fails (which apparently happens for some reason on MacOS), this causes an infinite recursion. I propose to fix this by creating a ViewProperties object for an empty URL instead and ensuring that the global view properties are loaded if the constructor is called with an empty KUrl.
Works for me, no regressions so far. Testing on MacOS would be appreciated!
Frank Reininghaus
Kurt Hindenburg
Commit Hook
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Loading...