Prevent Konqueror from performing lots of stat calls during session auto save

Review Request #111048 - Created June 16, 2013 and submitted

Information
Dawit Alemayehu
kde-baseapps
KDE/4.10
Reviewers
kde-baseapps
dfaure
The attached patch changes KonqSessionManager such that it creates an instance of the auto save session KConfig object once during initialization instead of each time it is invoked, which is about every 10 secs. This stops the flood of "stat" calls from Konqueror that occur every 10 secs even when  Konqueror is doing absolutely nothing. The problem and its fix can be tested by running Konqueror through strace, "strace -e stat konqueror".

The result of this fix is the number of stat calls Konqueror makes every 10 secs went down to 1 from 15. Even that remaining stat call can be stopped if I was certain that removing the "deleteOwnedSessions" call from autoSaveSession won't cause any regression. David?

  

Issues

  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Dawit Alemayehu
Rolf Eike Beer
David Faure
Dawit Alemayehu
David Faure
Commit Hook
Commit Hook
Dawit Alemayehu
Review request changed

Status: Closed (submitted)

Loading...