KFileItemModelRolesUpdater polishing, part 1: simplify preview job handling

Review Request #111008 - Created June 13, 2013 and submitted

Information
Frank Reininghaus
kde-baseapps
master
Reviewers
dolphin
This patch changes two things about the way we handle the preview job:

(a) Rather than passing a KFileItemList to startPreviewJob(), remembering the leftovers in a member variable and then starting a new preview job for these, I propose to just add items that need a preview to this KFileItemList member, and let startPreviewJob() take its input from there. Makes the code a lot simpler.

(b) To prevent that we start preview jobs with just 1 item and also that the GUI is frozen too long by startPreviewJob(), I propose the following method:

* If the mime type of the first pending item is known, the function has probably been called by startUpdating(), which has determined mime types for the visible items already. startUpdating() has also blocked the GUI, so we just take all items at the beginning of the list with known mime type, and do not do any expensive mime type determination in startPreviewJob().

* If the mime type of the first pending item is unknown, the function has probably been called by slotPreviewJobFinished(). In that case, we can affort to block the GUI for a short while, so we determine mime types for 200 ms.
Works for me.
Emmanuel Pescosta
Commit Hook
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Loading...