Fix Bug 319119 - Dolphin doesn't notice when renaming failed

Review Request #110922 - Created June 9, 2013 and submitted

Information
Emmanuel Pescosta
kde-baseapps
master
319119
Reviewers
dolphin, kde-baseapps
dfaure, freininghaus
Change the data in the model before the real renaming is done by KonqOperations::rename(),
but when the rename operation fails, revert the data changes in the model.

The problem is that DolphinView::slotRoleEditingFinished() changes the data in the model *before* the actual renaming is performed by KonqOperations/KIO.
But we need this approach for the following cases:
* Immediate feedback from the users point of view (No delay between finish renaming and DolphinView updates)
* Missing file system/dir lister signals, when there is no file system notification system (ftp, ssh, ...)

A lot of code in konq_operations.h and konq_operations.cpp is just copy and paste, to guarantee binary compatibility. (added some TODOs for KF 5.0)
Works for me.

Tested with a remote ssh file system on a virtual machine.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Faure
Emmanuel Pescosta
David Faure
Frank Reininghaus
Commit Hook
Emmanuel Pescosta
Review request changed

Status: Closed (submitted)

Loading...