DO not rename the wrong item when items are added to the view while renaming

Review Request #110909 - Created June 9, 2013 and submitted

Information
Frank Reininghaus
kde-baseapps
KDE/4.10
320823
Reviewers
dolphin
The problem is that KItemListRoleEditor remembers the index of the item that is currently being renamed, and finally tells DolphinView to rename the item with that index. However, the index might change if new files are added to the directory.

To fix this, I propose to not tell KItemListRoleEditor about the index at all. Instead, just let the KStandardItemListWidget (which always knows about the correct index) determine the index when renaming is finished, and forward that one to DolphinView.
Works for me.
Emmanuel Pescosta
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Change Summary:

http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=4de9a233642a62ee96bac6031340d3eea21f14f9

Note that the commit message is wrong because I messed up the local branches in my git repository clone.
Loading...