When changing the URL while renaming inline, abort renaming, rather than renaming an item in the new folder

Review Request #110908 - Created June 9, 2013 and submitted

Information
Frank Reininghaus
kde-baseapps
KDE/4.10
319912
Reviewers
dolphin
If the "role editor" loses focus, it considers the current renaming operation finished, and tells DolphinView to rename the file. This is a problem when changing the directory, because the URL change happens *before* DolphinView receives the signal, which results in a file in the new directory being renamed unexpectedly.

Currently, the DolphinView is connected to the "slotRoleEditingFinished" signal permanently. I propose to change this and only establish the connection when the "rename inline" editor is opened, and disconnect it when renaming is finished or canceled or the URL changes.
Works for me.
Emmanuel Pescosta
Commit Hook
Commit Hook
Frank Reininghaus
Review request changed

Status: Closed (submitted)

Loading...