Monitor for changes from PersonsDataSource

Review Request #110801 - Created June 3, 2013 and submitted

Information
David Edmundson
kpeople
Reviewers
apol, dvratil, mklapetek, vhanda
Monitor for changes from PersonsDataSource
    
Add a new class DataSourceWatcher that monitors speific contactIDs
    
PersonsModel and PersonData are then updated to use it.
    
ContactURIs are mapped to save searching through the entire model
Opened contact-list-kpeople went offline online everyone updates immediately :)

Issues

  • 3
  • 2
  • 0
  • 5
Description From Last Updated
From the QHash docs - "Returns the value associated with the key. If the hash contains no item with the ... Vishesh Handa Vishesh Handa
This is probably another nitpick - Why check if the resource has the property and then iterate over all the ... Vishesh Handa Vishesh Handa
...and unless I'm missing something very important, PersonsModel is leaking the private struct as well. Daniel Vrátil Daniel Vrátil
Vishesh Handa
Daniel Vrátil
Daniel Vrátil
Daniel Vrátil
Vishesh Handa
Commit Hook
David Edmundson
Review request changed

Status: Closed (submitted)

Loading...