Bug 315017 - kded crashed while plug off the A/C

Review Request #110746 - Created May 31, 2013 and submitted

Information
Kai Uwe Broulik
kde-workspace
KDE/4.10
315017
Reviewers
solid
dantti
Fix Bug 315017 - kded crashed while plug off the A/C

There's a Qt bug which makes the application crash when you try to access a QDBusPendingReply value when it is invalid. This patch makes it check if the reply is valid before trying to access it.
Compiles.

Issues

  • 3
  • 0
  • 0
  • 3
Description From Last Updated
I do not like waitForFinished() calls. However, this is not part of your patch, so need to worry. Lamarque Souza Lamarque Souza
isActive can be const here. Lamarque Souza Lamarque Souza
As a small optimization you could add rp.isValid() to the if clause instead of creating a temporary variable (isActive). Lamarque Souza Lamarque Souza
Lamarque Souza
Kai Uwe Broulik
Dario Freddi
Commit Hook
Commit Hook
Kai Uwe Broulik
Review request changed

Status: Closed (submitted)

Loading...