Playlist sort widget: reimplement Shuffle "sort" as an action.

Review Request #110658 - Created May 27, 2013 and submitted

Information
Konrad Zemek
amarok
Reviewers
amarok
Playlist sort widget: reimplement Shuffle "sort" as an action.

Remove now-unnecessary Shuffle handlers in sort-related functions. Additionally, PlaylistController::MoveRows has been modified to help with big move actions (validation complexity reduced).

Playlist::BreadcrumbItemMenu introduced to deduplicate logic between Playlist::BreadcrumbItem and Playlist::BreadcrumbAddMenuButton.

GUI: In the playlist sort widget, the Shuffle menu entry is now separated from other entries. Activating the entry no longer results in a "Shuffle" sort level being added.
BUG: 320129
FIXED-IN: 2.8
REVIEW: 110658
Test added for the shuffle action. GUI tested manually.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
1. Nice way to checking every item is there just once! ;) 2. I think that fromItems == toItems is ... Matěj Laitl Matěj Laitl
Matěj Laitl
Andreas Hartmetz
Edward Toroshchin
Konrad Zemek
Matěj Laitl
Konrad Zemek
Matěj Laitl
Commit Hook
Konrad Zemek
Review request changed

Status: Closed (submitted)

Loading...