KMix: improve the appearance of the "Select Master Channel" dialogue
Review Request #110645 - Created May 25, 2013 and submitted
The current dialogue, with its scolling list of radio buttons, does not look good and is not consistent with the channel lists as displayed elsewhere in KMix. The buttons have no margin, the scrolling list is the same colour as the background, and there are no icons for visual cues. This change displays the channels as a list, in the same way as the "Configure Channels" dialogue. The current master channel shown by the highlighted item. As an added bonus, the widget structure and code is simpler.
Build KMix with these changes, checked appearance and operation of the dialogue with 2 different sound cards.
Hello Jonathan, thanks for "ping-ing", as it is very easy too miss reviews. I checked the KDE HIG, and I would say your change is appropriate. From http://techbase.kde.org/Projects/Usability/HIG#Selection : - Use radio buttons for selection of 1 out of a few items. <<< Current solution - Use a list view to select 1 singular item out of a potentially big list. <<< proposed solution I had not yet tested it, but is it still scrollable? This is required, as some cards have 30 or even 50 controls.
Thanks for your patch. KMix looks nicer with it. Aplogies for the delay, but now I found some real time sitting in a KDE Sprint (Randa/CH 2014). There are 3 chunks that cannot be applied plainly any longer, but I will apply them by hand. I will commit them soon.