Searchprovider dialog: add insert query placeholder button

Review Request #110423 - Created May 14, 2013 and submitted

Information
Maarten De Meyer
kde-runtime
146879
Reviewers
kde-runtime
This adds a 'Insert query placeholder' button to the add/modify web shortcut dialog.
-Clicking this button inserts \{@} in the shortcut URL lineEdit.
-The button is only enabled when the shortcut URL lineEdit has focus.

This makes it easy to add new web shortcuts. Users don't have to remember and type the query placeholder.

The eventfilter complicates this patch a lot. But there is no slot to detect if a lineedit has focus.
We could drop it but it looks messy when the button is always enabled.
I feel the tooltip text can be improved. Any suggestions from a native English speaker?
Added a new shortcut.
Changed focus to and from different widgets.
Inserted placeholder at the end of the link and in the middle.
Modified a shortcut.

Files


Issues

  • 0
  • 1
  • 1
  • 2
Description From Last Updated
Maarten De Meyer
Maarten De Meyer
Dawit Alemayehu
Maarten De Meyer
Maarten De Meyer
Dawit Alemayehu
Commit Hook
Maarten De Meyer
Review request changed

Status: Closed (submitted)

Loading...