PlacesPanel: Do not allow drop events into timeline or search folder
Review Request #110348 - Created May 7, 2013 and submitted
PlacesPanel: Do not allow drop events into timeline or search folder They are read only. You cannot modify them, so it makes no point showing the "Move/Copy Into" context menu. Maybe we should show an error?
Hello Vishesh, thanks for helping us, to polish Dolphin for the KDE/4.11 release. :) > Maybe we should show an error? Error message really? I think a normal info message (yellow) would be enough. There are some small UI problems in Dolphin with the KMessageWidget, because it moves the whole view down. (see comment from Thomas Lübking - https://git.reviewboard.kde.org/r/110327/). I think we should move the KMessageWidget beneath the DolphinView and implement auto-disappearing for normal info messages. (Error messages should stay until the user closes it) - So the user is always informed why things (in this case dropping on timeline and search folders) doesn't work, but without annoying UI moves. ;) @Frank: What do you think?
Thanks for the patch! I'm fine with this suggestion (after considering Emmanuel's comments and adjusting the spaces in the 'if' statement to the kdelibs coding style). I think we should not show an error message for this - IMHO, this is a bit too intrusive. From my point of view, the optimal solution would be to show the "drop forbidden" cursor when hovering one of these items, then we would not have this problem at all. @Emmanuel: I'm not entirely sure what the best position for the message widget is, but as long as only serious errors (like those which prevent opening the URL, such that no files are shown at all) are shown in the KMessageWidget, the moving should not be a big issue, I think.