Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #110304 -
Created May 4, 2013 and discarded
May 4, 2013, 8:28 p.m.
The private class is not used and the pointer just increases the object size by 8bytes on a 64bit machine.
Doesn't that change the size of VCardLine?
Yes, thats the whole point. VCardLine is not exported though so it should not matter.
Are you sure? I checked the CMakeLists.txt of the directory and it installs vcardline.h and it is a .h and not a _p.h so I think it is public API.
Maybe the reason d is currently not used is that its need got removed but itself could not due to BC rules?
It's missing the export macro though.
Yes, but that only affects build that have visibilty-hidden enabled, no?
KDE does not ship any binary packages yet we still commit to BC within a major release. I don't think we can simply rule out one option for of building our code
Without the export macro you cannot use it from a different compile unit. Afaik KDE's cmake setup also ensures that this fails even on Linux, and not only on platforms where this is commonly enabled (like Windows).
Anyhow, discarded it now.
OK, I was used to export macro == public, otherwise private. Discarding this then.