move focus to another view upon drop
Review Request #110167 - Created April 25, 2013 and submitted
Ok, here's my own solution with 312834, when drop the view, activate it. Workflow: Open dolphin goto another folder split, open removable media or remote network place drag from origin view to splitted view close split Now close split still code the "acitve" one, but since the active one is moved to the dragged one, close will not require user to change back to the old view.
Seems working. Test case: 1. drag from other application to inactive dolphin window, dolphin window didn't get focus 2. workflow in description.
Thanks for the patch! I'm always a bit unsure about behaviour changes which might affect people's workflows, but in that case, it seems unlikely to me at the moment that it will cause problems for anyone. Does anyone else see a problem with this approach that we might be overlooking?
You only activate the DolphinView here, but the KUrlNavigator will stay inactive. This may trigger the "Q_ASSERT(m_view->isActive() == m_urlNavigator->isActive());" in DolphinViewContainer::isActive(). Possible solutions: * Use DolphinViewContainer->setActive(bool) instead * Or connect the DolphinView::activated() signal with the DolphinViewContainer::activate() slot (Like the KUrlNavigator in DolphinViewContainer does) [I think this is the better solution]