PopupItem QML component for KGamePopupItem

Review Request #110137 - Created April 23, 2013 and discarded

Information
Viranch Mehta
libkdegames
Reviewers
Kdegames
Implements a QML component KgCore.PopupItem for KGamePopupItem widget. Most of the properties of KGamePopupItem are provided by PopupItem, except ability to set the background brush (can set background color instead), and ability to set a custom QPixmap as icon (can set KIcon's name instead and switch showing icon on/off instead).

Although one of the critical downside is it cannot set theme based background and text colors. Not sure how to overcome this. But at least we have the component for starting to use in ports.
The KMines port (viranch/qtquick branch in kmines) uses this component (src/qml/main.qml) for showing "paused" message when game is paused/unpaused. works as expected except themed colors.

Issues

  • 3
  • 0
  • 0
  • 3
Description From Last Updated
Is this hardcoded to that color in the cpp too? Albert Astals Cid Albert Astals Cid
This hardcoded 32 feels a bit wrong, can we get something better? Is this what the cpp code is using? ... Albert Astals Cid Albert Astals Cid
is this hardcoded to white in the cpp version? Albert Astals Cid Albert Astals Cid
Albert Astals Cid
Albert Astals Cid
Viranch Mehta
Review request changed

Status: Discarded

Change Summary:

Discarding as discussed here.
Loading...